Repository navigation
Preserve pending Effects toggles across save refreshes - #53496
Merged
copyberry[bot] merged 1 commit intoOct 12, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Saving an Effects preference refreshes the picker. When users toggle repeatedly before saves finish, that refresh can discard newer choices and cause subsequent toggles to use stale values. ## What changed - Update Effects checkboxes immediately and track pending saves per row, preserving newer choices when an earlier save takes effect. - Preserve pending Composer stars choices while Animations disables the row, and clear pending state on a regular panel refresh. - Use the shared list toggle handling for Effects, including Space support, while giving configured key bindings precedence over Space toggling. ## Testing Add regression tests for repeated toggles across save refreshes, pending Composer stars choices while disabled, clearing pending state, and a Space cancel binding taking precedence over toggling. Update the Effects picker snapshot. GitOrigin-RevId: 847dcc2dfd40448c7adc56c8c40879db28b1fc39
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/847dcc2dfd40448c7adc56c8c40879db28b1fc39
branch
from
October 12, 2026 22:44
5b99cfc to
92caad7
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/847dcc2dfd40448c7adc56c8c40879db28b1fc39
branch
October 12, 2026 22:44
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
andersonwu2000
temporarily deployed
to
issue-triage
October 12, 2026 22:50 — with
GitHub Actions
Inactive
andersonwu2000
temporarily deployed
to
issue-triage
October 12, 2026 22:50 — with
GitHub Actions
Inactive
andersonwu2000
temporarily deployed
to
issue-triage
October 12, 2026 22:50 — with
GitHub Actions
Inactive
wegenework-cloud
temporarily deployed
to
issue-triage
October 12, 2026 23:03 — with
GitHub Actions
Inactive
wegenework-cloud
temporarily deployed
to
issue-triage
October 12, 2026 23:03 — with
GitHub Actions
Inactive
wegenework-cloud
temporarily deployed
to
issue-triage
October 12, 2026 23:03 — with
GitHub Actions
Inactive
wegenework-cloud
temporarily deployed
to
issue-triage
October 12, 2026 23:04 — with
GitHub Actions
Inactive
davidli8888
temporarily deployed
to
issue-triage
October 12, 2026 23:04 — with
GitHub Actions
Inactive
davidli8888
temporarily deployed
to
issue-triage
October 12, 2026 23:04 — with
GitHub Actions
Inactive
davidli8888
temporarily deployed
to
issue-triage
October 12, 2026 23:04 — with
GitHub Actions
Inactive
monnerHenster
temporarily deployed
to
issue-triage
October 12, 2026 23:05 — with
GitHub Actions
Inactive
monnerHenster
temporarily deployed
to
issue-triage
October 12, 2026 23:05 — with
GitHub Actions
Inactive
monnerHenster
temporarily deployed
to
issue-triage
October 12, 2026 23:05 — with
GitHub Actions
Inactive
monnerHenster
temporarily deployed
to
issue-triage
October 12, 2026 23:06 — with
GitHub Actions
Inactive
tom-stayner
temporarily deployed
to
issue-triage
October 12, 2026 23:18 — with
GitHub Actions
Inactive
tom-stayner
temporarily deployed
to
issue-triage
October 12, 2026 23:18 — with
GitHub Actions
Inactive
tom-stayner
temporarily deployed
to
issue-triage
October 12, 2026 23:18 — with
GitHub Actions
Inactive
aoyama104104-ui
temporarily deployed
to
issue-triage
October 12, 2026 23:24 — with
GitHub Actions
Inactive
aoyama104104-ui
temporarily deployed
to
issue-triage
October 12, 2026 23:24 — with
GitHub Actions
Inactive
aoyama104104-ui
temporarily deployed
to
issue-triage
October 12, 2026 23:24 — with
GitHub Actions
Inactive
aoyama104104-ui
temporarily deployed
to
issue-triage
October 12, 2026 23:25 — with
GitHub Actions
Inactive
LiuLawrence45
temporarily deployed
to
issue-triage
October 12, 2026 23:33 — with
GitHub Actions
Inactive
LiuLawrence45
temporarily deployed
to
issue-triage
October 12, 2026 23:33 — with
GitHub Actions
Inactive
LiuLawrence45
temporarily deployed
to
issue-triage
October 12, 2026 23:33 — with
GitHub Actions
Inactive
scottconverse
temporarily deployed
to
issue-triage
October 12, 2026 23:42 — with
GitHub Actions
Inactive
scottconverse
temporarily deployed
to
issue-triage
October 12, 2026 23:42 — with
GitHub Actions
Inactive
scottconverse
temporarily deployed
to
issue-triage
October 12, 2026 23:42 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve pending Effects toggles across save refreshes
Why
Saving an Effects preference refreshes the picker. When users toggle repeatedly before saves finish, that refresh can discard newer choices and cause subsequent toggles to use stale values.
What changed
Testing
Add regression tests for repeated toggles across save refreshes, pending Composer stars choices while disabled, clearing pending state, and a Space cancel binding taking precedence over toggling. Update the Effects picker snapshot.