Repository navigation
Fix package smoke tests for Cargo and Bazel debug symbols - #51849
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
## Why Cargo and Bazel embed different PDB filenames in the Windows code-mode host executable. The package smoke test must support both names while verifying that the debug symbols match the packaged executable. ## What changed - Keep the archived PDB and copy it to `codex_code_mode_host.pdb`, allowing `dumpbin /PDBPATH` to resolve either name. Accept either path in the assertion. - Set `sandbox_workspace_write.writable_roots = []` explicitly in the smoke-test configuration. GitOrigin-RevId: fc2610f580dad49e38848582bc63f1f829cb766d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/fc2610f580dad49e38848582bc63f1f829cb766d
branch
from
October 7, 2026 22:11
5a97767 to
391bf19
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/fc2610f580dad49e38848582bc63f1f829cb766d
branch
October 7, 2026 22:11
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix package smoke tests for Cargo and Bazel debug symbols
Why
Cargo and Bazel embed different PDB filenames in the Windows code-mode host executable. The package smoke test must support both names while verifying that the debug symbols match the packaged executable.
What changed
codex_code_mode_host.pdb, allowingdumpbin /PDBPATHto resolve either name. Accept either path in the assertion.sandbox_workspace_write.writable_roots = []explicitly in the smoke-test configuration.