Repository navigation
chore: remove dead EntityStatsTracker (single-server) class - #36490
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
detail-app
Bot
added
the
safe to test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the legacy single-server
EntityStatsTrackerand itsJobStatsManagerwrapper, plus their unit tests. These had zero production callers after the
single-server indexing path was retired in "Make SearchIndexing distributed-only"
(#27971), which deleted
SearchIndexExecutor— the only production consumer.JobStatsManager(the sole remaining referent ofEntityStatsTracker) was itselfunreferenced in production, leaving only the unit tests as consumers. The
distributed pipeline uses
StageStatsTracker(the production default, per thein-file comment added in #27865).
History
Dead Code PRs can be configured here.