Skip to content

Add Cache Warmup app schema to UI - #25938

Merged
TeddyCr merged 4 commits into
open-metadata:mainfrom
DengYiping:ydeng/cache-warmup-app-schema
Mar 20, 2026
Merged

TeddyCr merged 4 commits into
open-metadata:mainfrom
DengYiping:ydeng/cache-warmup-app-schema

Conversation

@DengYiping

@DengYiping DengYiping commented Feb 17, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes N/A (no issue)

  • Add Cache Warmup app JSON schema to UI application schemas so the config editor renders.

I worked on adding the Cache Warmup application schema to the UI because the configuration editor was showing undefined without it.

No UI screenshots; schema-only change.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

No migration needed; UI-only schema file.


Summary by Gitar

  • New application schema: Added CacheWarmupApplication.json schema to UI enabling configuration editor to render Cache Warmup app settings instead of undefined
    • Defines configuration options: entities list, batch size (10-1000), consumer threads (1-10), queue size (100-10000), and force flag

This will update automatically on new commits.

@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Feb 20, 2026 •

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.99% (58007/89242) 44.77% (30676/68513) 47.75% (9176/19213)

@harshach

harshach commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

@DengYiping we need to bit more work than just restarting this. Would you open to working with us to test some of cache capabilities and we happy to add where the cache is needed and resolve any gaps

@DengYiping

Copy link
Copy Markdown
Contributor Author

Would you open to working with us to test some of cache capabilities and we happy to add where the cache is needed and resolve any gaps

I am more than happy to test out everything with your team. Let me know if you need help anywhere.

@TeddyCr
TeddyCr enabled auto-merge (squash) March 20, 2026 18:45
@github-actions

Copy link
Copy Markdown
Contributor

❌ App Docs Check Failed

Generated app docs are stale. Changed files:

  • openmetadata-ui/src/main/resources/ui/public/locales/en-US/Applications/CacheWarmupApplication.md

Fix locally:

cd openmetadata-ui/src/main/resources/ui
yarn generate:app-docs

@gitar-bot

gitar-bot Bot commented Mar 20, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

Adds Cache Warmup app schema to the UI with clean integration. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@TeddyCr
TeddyCr merged commit ef6c9cd into open-metadata:main Mar 20, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (18 flaky)

✅ 3391 passed · ❌ 0 failed · 🟡 18 flaky · ⏭️ 183 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 454 0 1 2
✅ Shard 2 305 0 0 1
🟡 Shard 3 670 0 5 33
🟡 Shard 4 684 0 4 41
🟡 Shard 5 668 0 4 73
🟡 Shard 6 610 0 4 33
🟡 18 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › API Endpoint - customization should work (shard 1, 1 retry)
  • Features/BulkImport.spec.ts › Database (shard 3, 1 retry)
  • Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 3, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 3, 1 retry)
  • Features/ImpactAnalysis.spec.ts › Verify column level upstream connections (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should not display soft deleted assets in search suggestions (shard 4, 1 retry)
  • Flow/IngestionBot.spec.ts › Ingestion bot should be able to access domain specific domain (shard 4, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with deeply nested subdomains (3+ levels) verifies FQN propagation (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tag Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Glossary Term Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Tag Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Glossary Term Add, Update and Remove (shard 5, 1 retry)
  • Pages/Login.spec.ts › Refresh should work (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

pmbrull pushed a commit that referenced this pull request Mar 23, 2026

This branch was previously deployed

1 inactive deployment
test — 269c84eb Deployed Mar 20, 2026 by TeddyCr via playwright-ci-postgresql (1, 6) #38175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants