Conversation
Both tasks get POSTGRESQL_URL, the database's credentials included, and neither uses it: - ooniauth only sends login emails through SES and signs JWTs; it never opens a database session. - oonimeasurements reads ClickHouse only; it uses SQLAlchemy to build ClickHouse queries, not to connect to Postgres. That holds for master and for 636-better-pagination, which dev deploys. Checked in ooni/backend: neither service's code (outside the shared common/ package) uses PostgresDep, get_postgresql_session or settings.postgresql_url. The shared session is only built when a route asks for it, and without the variable the setting falls back to a local default. oonimeasurements' image ships the Postgres migrations, but they are only run by hand (make db-migration), with the URL read from Secrets Manager rather than from the task. The services that do use the database keep it: oonirun (OONI Run links), oonifindings (findings) and ooniprobe (VPN providers). terraform validate passes for dev and prod. Applying gives both services a task definition revision without the variable; the image is carried over from the current revision.
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @aagbsn |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Sun, 04 Oct 2026 05:55:51 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tasks get POSTGRESQL_URL, the database's credentials included, and neither uses it:
Checked in ooni/backend: neither service's code (outside the shared common/ package) uses PostgresDep, get_postgresql_session or settings.postgresql_url. The shared session is only built when a route asks for it, and without the variable the setting falls back to a local default. oonimeasurements' image ships the Postgres migrations, but they are only run by hand (make db-migration), with the URL read from Secrets Manager rather than from the task.
The services that do use the database keep it: oonirun (OONI Run links), oonifindings (findings) and ooniprobe (VPN providers). terraform validate passes for dev and prod. Applying gives both services a task definition revision without the variable; the image is carried over from the current revision.