Skip to content

ci: use pnpm/setup and devEngines - #450

Merged
danielroe merged 3 commits into
mainfrom
pnpm-setup
Sep 9, 2026
Merged

danielroe merged 3 commits into
mainfrom
pnpm-setup

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

this uses the new https://github.com/pnpm/setup github action to replace actions/setup-node + corepack, as corepack is going away in node 26+ 😢

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nuxt-hackernews Ready Ready Preview, v0 Sep 9, 2026 7:16am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 71d93310-365c-4b8c-b879-70e234774f20

📥 Commits

Reviewing files that changed from the base of the PR and between 47f4861 and fb49aa9.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .node-version
  • package.json

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The package manifest replaces packageManager with devEngines entries for Node.js ^24.0.0 and pnpm 12.3.4. The CI workflow replaces Corepack and Node setup with pnpm/setup, while retaining the later pnpm install step.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fb49a

This updates CI package-manager setup and runtime declarations for Node.js 24 and pnpm 12.3.4. The configuration is internally consistent, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: replacing the CI setup with pnpm/setup and adding devEngines.
Description check ✅ Passed The description accurately explains the CI changes and the reason for replacing Corepack.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pnpm-setup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 9, 2026

Copy link
Copy Markdown

Deploying hackernews with  Cloudflare Pages  Cloudflare Pages

Latest commit: fb49aa9
Status: ✅  Deploy successful!
Preview URL: https://47159bbe.hackernews-40s.pages.dev
Branch Preview URL: https://pnpm-setup.hackernews-40s.pages.dev

View logs

@danielroe
danielroe merged commit 433e235 into main Sep 9, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview fb49aa90 Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant