New value 149 for FOG#74
Open
HansChaudry wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing
client.get("New York"), I encountered aValueErrorbecause weather code149is not recognized by theKindenum.The upstream API response identifies weather code
149as smoky haze. At the time, smoke from Canadian wildfires was affecting the northeastern United States.As wildfire smoke events become more common, this code may appear more frequently. I propose adding
149as an associated value forKind.FOG, since it is the closest existing category. A dedicatedSMOKEorHAZEenum value could also be considered if greater specificity is preferred.Error:

Raw json from
curl -L "https://wttr.in/New+York?format=j1"