Skip to content

ci: use node-version-file in setup-vp actions - #3367

Merged
alexdln merged 4 commits into
mainfrom
roman/use-node-version-file-in-ci
Oct 29, 2026
Merged

alexdln merged 4 commits into
mainfrom
roman/use-node-version-file-in-ci

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

None

🧭 Context

CI currently sets node-version to lts/*

Yesterday Node 26 became the new LTS version

This broke CI because better-sqlite3 dependency doesn't build with Node 26

📚 Description

Updates setup-vp actions to use node-version-file instead of node-version since we already have a .node-version file

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Oct 29, 2026 2:03am UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Oct 29, 2026 2:03am UTC
npmx-lunaria Ignored Ignored Oct 29, 2026 2:03am UTC

Request Review

@gameroman
gameroman requested a review from a team October 29, 2026 01:52
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1be95d6 and 2f31ac0.

Files selected for processing: 7
  • .github/workflows/autofix.yml
  • .github/workflows/chromatic.yml
  • .github/workflows/ci.yml
  • .github/workflows/deploy-canary.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/release-pr.yml
  • .github/workflows/release-tag.yml
Files skipped from review as they are similar to previous changes: 7
  • .github/workflows/autofix.yml
  • .github/workflows/deploy-canary.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/release-pr.yml
  • .github/workflows/release-tag.yml
  • .github/workflows/chromatic.yml
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • CI, deployment and release workflows now use the project’s specified Node.js version rather than automatically selecting the latest LTS release, keeping automated tasks aligned with the configured version.

Workflow setup steps now read the Node.js version from .node-version instead of selecting lts/*. This applies to CI jobs and the autofix, Chromatic, canary deployment, Lunaria, release PR and release tag workflows.

Changes: Workflow Node.js version configuration

Layer / File(s) Summary
Use the repository Node.js version
.github/workflows/autofix.yml, .github/workflows/chromatic.yml, .github/workflows/ci.yml, .github/workflows/deploy-canary.yml, .github/workflows/lunaria.yml, .github/workflows/release-pr.yml, .github/workflows/release-tag.yml
The workflow setup steps now read the Node.js version from .node-version instead of selecting lts/*.

Suggested reviewers: ghostdevv

Priority: Pending latest changes

Merge Risk: Minimal · previous review 2f31a

The workflows now select Node.js from the repository version file rather than following the latest LTS release. No actionable merge-blocking issue was found; the change is ready to merge subject to normal workflow checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly summarises the main change: using node-version-file in setup-vp actions across the CI workflows.
Description check Passed The description explains the CI failure caused by Node 26 becoming the LTS release and describes the change to use the existing .node-version file.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gameroman gameroman changed the title fix(ci): use node-version-file in ci ci: use node-version-file in setup-vp actions Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman

Copy link
Copy Markdown
Member Author

I think the lunaria workflow is failing because it's using pull_request_target and should work when it's merged

@alexdln
alexdln added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 29, 2026
@alexdln
alexdln added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit c2e335f Oct 29, 2026
34 of 36 checks passed
@alexdln
alexdln deleted the roman/use-node-version-file-in-ci branch October 29, 2026 07:27

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — 14325f7e Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants