Repository navigation
fix: show install commands for vp, nub, ni and upm - #3351
Conversation
The data-pm show rules only covered npm, pnpm, yarn, bun, deno and vlt, so selecting one of the newer package managers left its command hidden in both the install dropdown and the additional commands list.
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @2u841r. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: showing install commands for the vp, nub, ni and upm package managers. |
| Description check | |
The description is directly related to the changes. It explains the missing CSS rules, affected files, verification performed and test coverage limitations. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Linked issue
No linked issue.
Context
The install command dropdown and the "additional commands" list only show the command for the selected package manager when a matching
data-pmrule exists. The CSS rules covered npm, pnpm, yarn, bun, deno and vlt, but not vp, nub, ni or upm (added in #3296). Selecting one of those four left its command hidden.Description
Adds
display: inlineshow rules forvp,nub,niandupmnext to the existing ones in:app/components/Package/Install/Dropdown.vue(data-pm-cmd)app/components/Package/Install/AdditionalCommands.vue(data-pm-additional-cmd)No logic changes. Verified in the browser on
/package/reactby settingdata-pmto each of the four values and checking computeddisplay: all four are nowinline.Not covered: no unit or e2e test was added for the CSS rules, and the dropdown selection flow itself was not clicked through.