Skip to content

ci: disable e18e action duplicate dep PR comments #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Apr 20, 2026
Merged

ci: disable e18e action duplicate dep PR comments #2593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/dependency-diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ jobs:
with:
mode: artifact
detect-replacements: 'true'
duplicate-threshold: '4'
# Too noisy. Disabling until this can report on duplicate CHANGES in this PR.
duplicate-threshold: '999'
Comment on lines +38 to +39

@coderabbitai coderabbitai Bot Apr 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鈿狅笍 Potential issue | 馃煛 Minor

馃З Analysis chain

馃弫 Script executed:

#!/bin/bash
# Description: Check the e18e/action-dependency-diff documentation for duplicate-threshold parameter

# Fetch the action's README and action.yml to verify the parameter
rg -i 'duplicate-threshold' --type yaml --type md -C 5

Repository: npmx-dev/npmx.dev

Length of output: 43

馃寪 Web query:

e18e/action-dependency-diff v1.5.0 duplicate-threshold parameter documentation

馃挕 Result:

No documentation found for a "duplicate-threshold" parameter in e18e/action-dependency-diff v1.5.0. The repository exists (https://github.com/e18e/action-dependency-diff), is public with 113 stars, and reports dependency changes in pull requests. However, searches across issues, README, action.yml, and releases did not reveal any mention of "duplicate-threshold". It may be an internal option, misremembered parameter name, or from a different version/tool. Check the action.yml file directly at https://github.com/e18e/action-dependency-diff/blob/v1.5.0/action.yml or contact the maintainer.

Citations:

The duplicate-threshold parameter does not appear to be supported by this action.

Web searches and action documentation do not show a duplicate-threshold parameter in e18e/action-dependency-diff v1.5.0. This setting may not be having any effect. Either verify the parameter name against the action.yml file directly, test whether the threshold actually works as intended, or consider removing this configuration if it is not functioning.

馃 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/dependency-diff.yml around lines 38 - 39, The workflow
uses an unsupported parameter "duplicate-threshold" for the
e18e/action-dependency-diff v1.5.0 action; inspect the action's action.yml in
that release (or the action docs) to confirm the correct input name or behavior,
then either remove "duplicate-threshold: '999'" if no such input exists or
replace it with the exact supported input key and value (or implement a
different mechanism to suppress noisy output), ensuring the change targets the
entry named "duplicate-threshold" in the workflow and references the action
e18e/action-dependency-diff@v1.5.0 when validating.

dependency-threshold: '15'
size-threshold: '200000'

Expand Down
Loading