Repository navigation
[8.0] Translate ToString() on string expressions - #4052
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #4047 (5374dda) to
hotfix/8.0.12.Return string-mapped expressions unchanged from
NpgsqlObjectToStringTranslator, matching SQL Server and SQLite without introducing casts or changing null propagation.Preserves the original regression coverage for a string predicate, null propagation, and object-typed string grouping keys used in
OrderByandWhere. Since EF Core 8 predates theStringTranslationssuite, these tests use the existing Northwind functions suite and run synchronously and asynchronously. Also adds the inheritedToString_string_property_projectionSQL assertions for GearsOfWar, TPC, and TPT.Validation: all 54
ToStringfunctional tests passed with .NET SDK 8.0.425 and VSTest against a dedicated PostgreSQL 16 container. All eight new regression cases failed with translation errors before the fix. No shared database or provisioning code changes.Fixes #4046.
Related to dotnet/efcore#20839 and its upstream fix dotnet/efcore#29349.