Repository navigation
Fix Home gesture interception and stabilize Expo compatibility CI - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Returning from Home to All napplets no longer reveals a focused card below the viewport because revealCard runs before the overview list remounts, leaving the scroll position unrestored.
1 open issue
What changed in this PR
This PR prevents hidden overview controls from intercepting Home taps while keeping live napplet views mounted to preserve temporary state.
Changes:
- Unmount overview controls while Home is visible.
- Disable native scrolling and card gestures whenever the overview is inactive.
| File | Description |
|---|---|
src/shell/WorkspaceStage.tsx |
Conditionally mounts overview controls without unmounting live sessions. |
src/shell/Overview.tsx |
Disables inactive gestures and removes the obsolete hidden prop and style. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hidden overview gesture handlers could intercept taps while Home was visible on iOS, including switching napplets during unpinning. The overview controls now unmount on Home, and their native gestures are disabled whenever inactive. Live napplet views remain mounted, preserving temporary state. Returning from Home also restores the focused card after both the overview viewport and content have laid out, keeping native and animated scroll offsets aligned.
The Expo compatibility gate now validates installed packages against the compatibility map shipped with the exact pinned SDK, then runs the remaining Expo Doctor checks. Latest remote upgrade recommendations remain visible in a separate advisory CI step. This avoids demanding newly released patches that conflict with the seven-day release-age policy. Incompatible packages, other Doctor findings and security audits remain blocking; dependency pins, lockfiles and release-age rules are unchanged. Packaged notice fingerprints were regenerated from both production exports with all contributor identities and notice bytes unchanged.
Validation:
The phone smoke test predates the final overview scroll restoration. Ordinary physical acceptance remains separate from that smoke test and the Simulator regressions. All applicable CI jobs passed on
63f35f5: final CI run, including Android and iOS Release builds. The main-only score badge job is intentionally skipped for PRs.