Skip to content

Fix Home gesture interception and stabilize Expo compatibility CI - #11

Merged
macro88 merged 3 commits into
mainfrom
feat/pinned-napplets
Nov 17, 2026
Merged

macro88 merged 3 commits into
mainfrom
feat/pinned-napplets

Conversation

@macro88

@macro88 macro88 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Hidden overview gesture handlers could intercept taps while Home was visible on iOS, including switching napplets during unpinning. The overview controls now unmount on Home, and their native gestures are disabled whenever inactive. Live napplet views remain mounted, preserving temporary state. Returning from Home also restores the focused card after both the overview viewport and content have laid out, keeping native and animated scroll offsets aligned.

The Expo compatibility gate now validates installed packages against the compatibility map shipped with the exact pinned SDK, then runs the remaining Expo Doctor checks. Latest remote upgrade recommendations remain visible in a separate advisory CI step. This avoids demanding newly released patches that conflict with the seven-day release-age policy. Incompatible packages, other Doctor findings and security audits remain blocking; dependency pins, lockfiles and release-age rules are unchanged. Packaged notice fingerprints were regenerated from both production exports with all contributor identities and notice bytes unchanged.

Validation:

  • Seven new compatibility regressions cover incompatible React/native packages, compatible patches, development dependencies, missing packages/maps and propagation of other Doctor failures; all 116 quality tests pass.
  • The 15 mapped dependencies match the installed SDK; all 19 remaining Expo Doctor checks pass.
  • TypeScript, both platform exports, 84 notice tests and native notice-packaging checks pass. React Doctor and AISlop each score 100/100; all ten dependency audits pass.
  • The scroll restoration passes three regressions covering native layout event ordering, retained offsets and bounds after content changes. All 104 shell tests pass. A focused iPhone Simulator test with 20 napplets confirms that the last card is visible after Home and retains its counter when reopened. The disposable app and runner were removed and the original Simulator app inventory verified.
  • The gesture fix passed complete iPhone Simulator and Android emulator Home journeys, including pinning, logo-to-Home, retained temporary state, unpinning without closing and persisted removal of Discover. Both native builds and 101 shell tests passed. The owner reports that the signed Android build installed over the official app works well.

The phone smoke test predates the final overview scroll restoration. Ordinary physical acceptance remains separate from that smoke test and the Simulator regressions. All applicable CI jobs passed on 63f35f5: final CI run, including Android and iOS Release builds. The main-only score badge job is intentionally skipped for PRs.

Copilot AI balanced review requested due to automatic review settings November 16, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Returning from Home to All napplets no longer reveals a focused card below the viewport because revealCard runs before the overview list remounts, leaving the scroll position unrestored.

1 open issue
What changed in this PR

This PR prevents hidden overview controls from intercepting Home taps while keeping live napplet views mounted to preserve temporary state.

Changes:

  • Unmount overview controls while Home is visible.
  • Disable native scrolling and card gestures whenever the overview is inactive.
File Description
src/​shell/​WorkspaceStage.tsx Conditionally mounts overview controls without unmounting live sessions.
src/​shell/​Overview.tsx Disables inactive gestures and removes the obsolete hidden prop and style.

Review effort: Balanced

Comment thread src/shell/WorkspaceStage.tsx Resolved
@macro88 macro88 changed the title Prevent hidden overview gestures from intercepting Home taps Fix Home gesture interception and stabilize Expo compatibility CI Nov 16, 2026
@macro88
macro88 merged commit 9155117 into main Nov 17, 2026
16 checks passed
@macro88
macro88 deleted the feat/pinned-napplets branch November 17, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants