Skip to content

Bump php minimum version & fix deprecations - #67

Merged
norberttech merged 16 commits into
norberttech:5.xfrom
simplesurance:6.x
Dec 21, 2023
Merged

Bump php minimum version & fix deprecations#67
norberttech merged 16 commits into
norberttech:5.xfrom
simplesurance:6.x

Conversation

@nocive

@nocive nocive commented Dec 14, 2023

Copy link
Copy Markdown
Contributor
  • fixed several deprecations & slightly modernized the code
  • deps: bump php minimum version to 8.1
  • deps: bump symfony minimum version to 5.4
  • deps: bump twig minimum version to 2.0
  • deps: bump php-cs-fixer to 3.16
  • update php-cs-fixer configuration

@nocive

This comment was marked as outdated.

@nocive

This comment was marked as outdated.

Comment thread composer.json Outdated
Comment thread composer.json Outdated
Comment thread .gitignore Outdated
@nocive

This comment was marked as resolved.

@nocive

This comment was marked as outdated.

Comment thread .github/workflows/static-analyze.yml Outdated
Comment thread composer.json Outdated
Comment thread composer.json Outdated
Comment thread .github/workflows/static-analyze.yml Outdated
@nocive

nocive commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

@norberttech perhaps you want to keep composer.lock in git because of renovate bot? It was an unusual sight for me in a library, hence why I removed and gitignored it.

@norberttech

Copy link
Copy Markdown
Owner

@norberttech perhaps you want to keep composer.lock in git because of renovate bot? It was an unusual sight for me in a library, hence why I removed and gitignored it.

yeah, dependabot is precisely why I'm keeping composer.lock across all my projects. It helps me identify issues with specific versions after automated upgrades that normally I would not even notice. I would appreciate if you could revert that one change. After that it will be good to merge, amazing work! 🎉

@nocive

nocive commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

done! thanks, happy I could help ;)

@norberttech

Copy link
Copy Markdown
Owner

To keep composer.lock working correctly, you need to locally use PHP 8.1 in order to generate lock in a version that should work across all supported PHP versions.

@norberttech

Copy link
Copy Markdown
Owner

To keep composer.lock working correctly, you need to locally use PHP 8.1 in order to generate lock in a version that should work across all supported PHP versions.

oh and you don't need to use --prefer-lowest, just composer update with php 8.1 should work just fine

@nocive

nocive commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

oof 😅 i think i got it now!

@norberttech
norberttech merged commit e337d15 into norberttech:5.x Dec 21, 2023
@norberttech

Copy link
Copy Markdown
Owner

Nice!! Thank you 🙏

@nocive

nocive commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

@norberttech I guess documentation updates are still missing in order to release the next version? Would be great to publish it eventually since the last stable is from 2019 💦

@norberttech

Copy link
Copy Markdown
Owner

yeah, there are still few more things missing, let me go through this repo an check what would be needed for next stable release, I'm going to create a mileston with issues, once all issues are solved we can release next version.

@norberttech norberttech added this to the 5.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants