Skip to content

remove websocket experimental warning - #3311

Merged
KhafraDev merged 3 commits into
nodejs:mainfrom
KhafraDev:remove-websocket-experimental-warning
Jun 6, 2024
Merged

remove websocket experimental warning#3311
KhafraDev merged 3 commits into
nodejs:mainfrom
KhafraDev:remove-websocket-experimental-warning

Conversation

@KhafraDev

Copy link
Copy Markdown
Member

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

;)

ghost commented Jun 5, 2024

Copy link
Copy Markdown
Member Author

I don't understand the test failures. cc @metcoder95

ghost commented Jun 5, 2024

Copy link
Copy Markdown
Member

const assert = tspl(t, { plan: 8 })

Could you change this plan to six?

ghost commented Jun 6, 2024

Copy link
Copy Markdown
Member Author

thanks, I wonder why the error message was different

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants