Skip to content

fix: keep raw header name - #3183

Merged
mcollina merged 8 commits into
nodejs:mainfrom
tsctx:fix/keep-raw-header-name
May 1, 2024
Merged

mcollina merged 8 commits into
nodejs:mainfrom
tsctx:fix/keep-raw-header-name

Conversation

@tsctx

@tsctx tsctx commented Apr 30, 2024 •

Copy link
Copy Markdown
Member

Follow up of #3160.
In the following cases. Lose the original raw header name.

await fetch(new Request(url, { headers: [['Content-Type', 'text/plain']] }), { method: 'GET' })

Comment thread lib/web/fetch/request.js Outdated
Comment thread test/fetch/headers-case.js Outdated
@codecov-commenter

codecov-commenter commented Apr 30, 2024 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (e009b0c) to head (8c33986).
⚠️ Report is 969 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3183   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          90       90           
  Lines       24434    24437    +3     
=======================================
+ Hits        23011    23014    +3     
  Misses       1423     1423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/web/fetch/request.js Outdated
Comment thread test/fetch/headers-case.js Outdated
@tsctx
tsctx marked this pull request as ready for review April 30, 2024 20:53
Comment thread lib/web/fetch/headers.js Outdated
Comment thread lib/web/fetch/headers.js Outdated
Comment thread lib/web/fetch/request.js Outdated
Comment thread lib/web/fetch/request.js Outdated
Comment thread lib/web/fetch/headers.js

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 0dcd59b into nodejs:main May 1, 2024
@tsctx
tsctx deleted the fix/keep-raw-header-name branch May 1, 2024 13:48
@github-actions github-actions Bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants