Skip to content

test: fix flakyness of issue-803 test - #2960

Merged
mcollina merged 2 commits into
nodejs:mainfrom
Uzlopak:perf-issue-803
Mar 14, 2024
Merged

test: fix flakyness of issue-803 test#2960
mcollina merged 2 commits into
nodejs:mainfrom
Uzlopak:perf-issue-803

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

will this reduce the flakyness in macos? we will see.

Improving he performance and increasing the timeout did the trick.

ghost commented Mar 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (3e59a2d) to head (cfb7fb4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          89       89           
  Lines       24158    24158           
=======================================
  Hits        22585    22585           
  Misses       1573     1573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost changed the title test: improve performance of issue-803 test test: fix flakyness of issue-803 test Mar 14, 2024
@ghost
ghost requested review from KhafraDev, mcollina, metcoder95 and ronag March 14, 2024 20:13

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost
ghost merged commit 07019d0 into nodejs:main Mar 14, 2024
@ghost
ghost deleted the perf-issue-803 branch March 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants