test_runner: display warn/error diagnostics with the dot reporter#64578
Open
Niruhqs wants to merge 5 commits into
Open
test_runner: display warn/error diagnostics with the dot reporter#64578Niruhqs wants to merge 5 commits into
Niruhqs wants to merge 5 commits into
Conversation
Threads a level ('warn') through rootTest.diagnostic() for the
coverage-related warnings, so reporters can distinguish them from
routine info diagnostics.
Signed-off-by: Maisto <ndbd2822@gmail.com>
…ntext
Test.prototype.diagnostic() now stores { message, level } instead of
a bare string, and TestContext/SuiteContext forward an optional level
argument (default 'info'). This is consumed by the dot reporter to
surface warn/error-level diagnostics, such as coverage failures.
Signed-off-by: Maisto <ndbd2822@gmail.com>
Previously the dot reporter only handled test:pass/test:fail events, so a warn/error-level diagnostic (e.g. a coverage collection failure) produced no visible output at all, only a non-zero exit code. This mirrors the coloring/symbol already used by the spec reporter. Fixes: nodejs#60884 Signed-off-by: Maisto <ndbd2822@gmail.com>
Reuses the existing coverage_failure.js fixture, which mocks TestCoverage.prototype.summary() to throw, and asserts the dot reporter's output against a new snapshot. Signed-off-by: Maisto <ndbd2822@gmail.com>
Signed-off-by: Maisto <ndbd2822@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the dot reporter only handled test:pass/test:fail events, so a warn/error-level diagnostic (e.g. a coverage collection failure) produced no visible output at all - just a non-zero exit code with no explanation.
This threads an optional level through Test.prototype.diagnostic() / TestContext / SuiteContext, marks the coverage-related diagnostics in harness.js as 'warn', and updates the dot reporter to display them using the same coloring/symbol already used by the spec reporter.
Fixes: #60884