Skip to content

src: fix comment typos#64488

Open
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:src/fix-comment-typos
Open

src: fix comment typos#64488
sjungwon03 wants to merge 1 commit into
nodejs:mainfrom
sjungwon03:src/fix-comment-typos

Conversation

@sjungwon03

Copy link
Copy Markdown
Contributor

Fix typos in source comments.

- // Eagerly compile primordials/boostrap/main scripts during code cache
+ // Eagerly compile primordials/bootstrap/main scripts during code cache

- // If any bulitins should be eagerly compiled i.e. with inner functions
+ // If any builtins should be eagerly compiled i.e. with inner functions

- // documentation suggets. As a compromise, we currently only block on
+ // documentation suggests. As a compromise, we currently only block on

- // that criticl user-blocking tasks are not lost.
+ // that critical user-blocking tasks are not lost.

- // If the stream is not a local undirectional stream and is_readable is
+ // If the stream is not a local unidirectional stream and is_readable is

Correct typos in builtin, platform, and QUIC source comments.

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (ed63b19) to head (8bbe15a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64488      +/-   ##
==========================================
- Coverage   92.01%   90.22%   -1.79%     
==========================================
  Files         381      741     +360     
  Lines      170167   241688   +71521     
  Branches    26075    45549   +19474     
==========================================
+ Hits       156585   218075   +61490     
- Misses      13291    15153    +1862     
- Partials      291     8460    +8169     
Files with missing lines Coverage Δ
src/node_builtins.cc 76.13% <ø> (ø)
src/node_builtins.h 100.00% <ø> (ø)
src/node_platform.cc 76.24% <ø> (ø)

... and 483 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants