Skip to content

http: client keep-alive for UNIX domain sockets#13214

Closed
bengl wants to merge 2 commits into
nodejs:masterfrom
bengl:bengl/unixkeepalive
Closed

http: client keep-alive for UNIX domain sockets#13214
bengl wants to merge 2 commits into
nodejs:masterfrom
bengl:bengl/unixkeepalive

Conversation

@bengl

@bengl bengl commented May 25, 2017

Copy link
Copy Markdown
Member

Makes Connection: keep-alive behave correctly when making client
connections to UNIX domain sockets.

Prior to this, connections would never be re-used, but the keep-alive
would cause the connections to stick around until they time out. This
would lead to an eventual EMFILE error due to all the connections
staying open. This was due to http.Agent not properly supporting UNIX
domain sockets.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http, test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants