Repository navigation
build: resolve subpath types under nodenext - #4757
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This was referenced Oct 9, 2026
tsconfig.node.json: moduleResolution 'nodenext' breaks nitro types in nuxt.config.ts
nuxt/nuxt#36481
Closed
pi0
approved these changes
Oct 13, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#36516
resolves nuxt/nuxt#36481
resolves nuxt/nuxt#36526
❓ Type of change
📚 Description
in nuxt v5, we will be switching the module resolution mode for
nuxt.configtonodenext, and in fact this is already enabled whencompatibilityVersion: 5.under
nodenext,nitropack/types,nitropack/runtimeandnitropack/presetsdo not type correctly, because the root shims containexport * from "./dist/types/index";(that is, they do not have a file extension - and therefore TS won't resolve it undernodenext)this PR rewrites the shims with a
.jsextension, which works fine undernode10,nodenextandbundleralike (fwiw, we have been patching nitro in the nuxt/nuxt repo since nuxt/nuxt#35943 - I should have raised this sooner!).📝 Checklist