Repository navigation
fix(externals): match string rules against windows ids - #4732
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
|
Installing this pull requests package with the pkg.pr link fixes the nuxt issue for me on windows |
The Windows package check failed in `nuxt generate` (the tauri beforeBuildCommand): every prerendered page answered 500 with "Either manifest or precomputed data must be provided". This is nuxt/nuxt#36467: on Windows, Nuxt 4.6.0's Nitro externals rule leaves the Vue renderer external, so the client manifest is never loaded. The fix (nitrojs/nitro#4732) is not merged or released yet. Linux and macOS are unaffected, which is why only the Windows job failed. - nuxt pinned to ~4.5.2; Dependabot ignores 4.6.0 only, so the first 4.6.x is still proposed and must pass the Windows package check. - Node baseline back to 22.12: the 22.21 requirement came from the @nuxt/cli that Nuxt 4.6 pulls in. - Hold documented in docs/dependency-policy.md; CHANGELOG corrected. Verified: bun run check (173 tests), bun run audit. The Windows build itself is verified by this push's CI run.
🔗 Linked issue
resolves nuxt/nuxt#36467
❓ Type of change
📚 Description
encountered this in a downstream issue with Nuxt 4.6.0 on Windows. every SSR page was returning a 500:
this was because string
externalsrules never match the id returned the resolver on Windows. that id is a backslash path (D:\some\path\index.js) butnormalizeMatchernormalises the pattern to forward slashes and then does a plainstartsWith...so this PR converts backslashes in the id to forward slashes (inside the string matcher only), so it lines up with the already-normalised pattern. the id that's returned and traced is unchanged, and function/RegExp matchers still get the raw id.
(I'm also opening a hotfix in nuxt itself but the correct fix here is in nitro, I think...)
📝 Checklist