Skip to content

fix(cloudflare): guard nodejs_compat flag by compatibility date #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 3 commits into from
Sep 25, 2026
Merged

fix(cloudflare): guard nodejs_compat flag by compatibility date #4663

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e7ea0a
fix(cloudflare): guard nodejs_compat flag by compatibility date
RihanArfan Sep 24, 2026
59cb22d
fix(cloudflare): keep nodejs_compat for dates before 2024-09-23
pi0 Sep 25, 2026
cd26a6e
Delete test/unit/cloudflare.utils.test.ts
pi0 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/presets/cloudflare/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ import {
unenvWorkerdWithNodeCompat,
} from "../_unenv/preset-workerd";

// https://github.com/nitrojs/nitro/issues/4527
const NODEJS_COMPAT_DEFAULT_ON_DATE = "2026-08-04";

export async function writeCFRoutes(nitro: Nitro) {
const _cfPagesConfig = nitro.options.cloudflare?.pages || {};
const routes: CloudflarePagesRoutes = {
Expand Down Expand Up @@ -358,7 +361,11 @@ export async function writeWranglerConfig(
);
} else {
// Add default compatibility flags
compatFlags.add("nodejs_compat");
// (`nodejs_compat` is enabled by default from 2026-08-04 and some workerd versions reject it explicitly)
const compatDate = wranglerConfig.compatibility_date;
if (!compatDate || compatDate < NODEJS_COMPAT_DEFAULT_ON_DATE) {
compatFlags.add("nodejs_compat");
}
compatFlags.add("no_nodejs_compat_v2");
}
}
Expand Down
Loading