[danielroe]

🔗 Linked issue

resolves nuxt/nuxt#33033
resolves nuxt/nuxt#29078

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

when a file can't be read because it can't be read from disk, we can return a 404 instead of a 500 error, which seems wrong.

alternatively, we could always return a 404 when the asset can't be read, if you didn't want to tie this too closely to fs semantics.

... or you may have another better idea!

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[vercel]

@danielroe is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 49d77314-528b-4489-9ccc-c51da5991a7f

📥 Commits

Reviewing files that changed from the base of the PR and between 4b07829 and b2eac39.

📒 Files selected for processing (1)

• src/build/virtual/public-assets.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/build/virtual/public-assets.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The static asset reader now returns undefined for missing files. The handler converts missing results into 404 errors for synchronous and asynchronous readers. Other read errors propagate unchanged. Empty assets remain valid responses.

Changes

Static asset handling

Layer / File(s)	Summary
Asset read pipeline src/build/virtual/public-assets.ts, src/runtime/internal/static.ts	The generated reader returns undefined for ENOENT. The handler validates synchronous and asynchronous results, clears Cache-Control, and throws a 404 for missing data. Other errors propagate unchanged.
Asset read validation test/unit/public-assets.test.ts, test/unit/static-middleware.test.ts	Tests cover missing-file resolution, EACCES propagation, synchronous and asynchronous 404 errors, cleared headers, and successful empty assets.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to b2eac

Missing static assets are handled as 404 responses, with no concrete unresolved merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the Conventional Commits format with the fix(static): prefix and accurately describes the missing public asset 404 behavior.
Description check	✅ Passed	The description is directly related to the changes. It explains the 404 behavior for unreadable or missing static assets and links the relevant issues.
Linked Issues check	✅ Passed	The implementation satisfies both linked issues. Missing assets resolve to a 404, while non-ENOENT read errors still propagate. The changes cover missing source maps and unavailable production public …
Out of Scope Changes check	✅ Passed	The implementation and tests are within scope. The added handling for synchronous readers, asynchronous readers, empty assets, and non-ENOENT errors supports the required static asset behavior.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4588

commit: b2eac39

[danielroe]

thank you @pi0 - this is a better approach ❤️