[sotasan]

🔍 Linked Issue

None — trivial type fix.

📚 Description

NitroPluginConfig.experimental.vite is currently typed as required, even though every field inside it is optional and every call site in src/build/vite/plugin.ts already reads it via optional chaining (pluginConfig.experimental?.vite?.…).

This makes any experimental override that doesn't include vite fail to typecheck. For example:

nitro({
  experimental: {
    tasks: true,
  },
})

…produces:

Property 'vite' is missing in type '{ tasks: true; }' but required in type '{ vite: { assetsImport?: boolean; serverReload?: boolean; services?: Record<string, ServiceConfig>; }; }'.

The workaround is experimental: { tasks: true, vite: {} }, but the empty object is meaningless — all three vite sub-options have defaults.

Change

One-character fix: vite: → vite?: in src/build/vite/types.ts. Aligns the declared type with actual runtime behavior.

No behavior change; no call site updates needed (they already optional-chain).

Checks

• pnpm typecheck — passes
• pnpm lint — passes
• pnpm test — passes except one pre-existing flake in test/vite/hmr.test.ts > editing SSR entry (no full-reload), which fails on clean main without this patch as well

[vercel]

@sotasan is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the NitroPluginConfig type to make the experimental.vite property optional instead of required. The inner optional settings (assetsImport, serverReload, services) remain unchanged in their structure and optionality.

Changes

Cohort / File(s)	Summary
Type Definition Updates src/build/vite/types.ts	Made experimental.vite property optional in NitroPluginConfig interface, allowing configurations without specifying the vite key while preserving inner optional properties.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title uses 'types' instead of 'fix' as the conventional commit type, which is technically valid but doesn't match the PR's primary purpose of fixing a type contract issue.	Consider updating the title to 'fix(vite): make experimental.vite optional' to better align with conventional commits for bug fixes, though 'types' is also acceptable for type-related changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description comprehensively explains the type-related issue, provides clear examples of the problem, documents the one-character fix, and references the verification steps taken.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pi0]

Thnx ❤️

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4225

commit: 0c8bf9e