Skip to content

presets(vercel): support max value on maxDuration types - #4172

Merged
pi0 merged 2 commits into
mainfrom
fix/vercel-max-duration-type
Apr 2, 2026
Merged

pi0 merged 2 commits into
mainfrom
fix/vercel-max-duration-type

Conversation

@RihanArfan

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Support the new max field on maxDuration for function configuration

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel

vercel Bot commented Mar 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nitro.build Ready Ready Preview, Comment Mar 31, 2026 8:42pm

Request Review

@RihanArfan
RihanArfan marked this pull request as ready for review March 31, 2026 20:40
@RihanArfan
RihanArfan requested a review from pi0 as a code owner March 31, 2026 20:40
@coderabbitai

coderabbitai Bot commented Mar 31, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the type definition of VercelServerlessFunctionConfig.maxDuration in the Vercel preset to accept either a number or the string literal "max", allowing configuration of maximum execution duration.

Changes

Cohort / File(s) Summary
Vercel Type Configuration
src/presets/vercel/types.ts
Updated maxDuration field type from number to number | "max" in the VercelServerlessFunctionConfig interface.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, explaining the enhancement to support the new max field on maxDuration for function configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title follows conventional commits format with 'presets(scope):' prefix and describes the main change clearly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/vercel-max-duration-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Mar 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4172

commit: 95586f4

@pi0 pi0 changed the title chore(vercel): support max value on maxDuration types presets(vercel): support max value on maxDuration types Apr 2, 2026
@pi0
pi0 merged commit 9479721 into main Apr 2, 2026
12 checks passed
@pi0
pi0 deleted the fix/vercel-max-duration-type branch April 2, 2026 08:10

This branch was successfully deployed

1 active deployment
Preview — 95586f4f Deployed Mar 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants