Repository navigation
perf(table): only check changed ranges for nested tables - #9576
Merged
Merged
Conversation
The filter preventing nested tables walked the whole document on every document change and resolved the position of every table, row and cell. Resolving is linear in the number of siblings, so typing in a long table got slower with every row. A nested table can only appear in content changed by the transaction, so only check the changed ranges, skip textblocks and only check table nodes: rows, cells, headers and captions can only exist inside a table. Benchmark on a 500 kB document with one table of 2,262 rows, median per keystroke in a cell in the middle of the table, before -> after: Chromium: - typing: 795 ms -> 672 ms - toggle bold (Ctrl+B): 797 ms -> 599 ms Firefox: - typing: 730 ms -> 487 ms - toggle bold (Ctrl+B): 936 ms -> 319 ms Related to #908 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
silverkszlo
approved these changes
Nov 9, 2026
Member
Author
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter preventing nested tables walked the whole document on every document change and resolved the position of every table, row and cell. Resolving is linear in the number of siblings, so typing in a long table got slower with every row.
A nested table can only appear in content changed by the transaction, so only check the changed ranges, skip textblocks and only check table nodes: rows, cells, headers and captions can only exist inside a table.
Benchmark on a 500 kB document with one table of 2,262 rows, median per keystroke in a cell in the middle of the table, before -> after:
Chromium:
Firefox:
Related to #908
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)