Skip to content

fix(DirectEditing): check if user is enabled - #8951

Merged
mejo- merged 2 commits into
mainfrom
fix/direct-editing
Aug 4, 2026
Merged

fix(DirectEditing): check if user is enabled#8951
mejo- merged 2 commits into
mainfrom
fix/direct-editing

Conversation

@silverkszlo

Copy link
Copy Markdown
Collaborator

馃摑 Summary

In directEditing sessions: check if user is enabled before letting them update the file

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@max-nextcloud max-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix looks good. The autoloader thing should probably be fixed separately. Ideally ahead of merging this so CI can run after a rebase.

Signed-off-by: silver <s.szmajduch@posteo.de>
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport! to stable34 please

@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport! to stable33 please

@max-nextcloud

Copy link
Copy Markdown
Collaborator

/backport! to stable32 please

@mejo-
mejo- merged commit 9540bf4 into main Aug 4, 2026
68 of 70 checks passed
@mejo-
mejo- deleted the fix/direct-editing branch August 4, 2026 08:43
@silverkszlo

Copy link
Copy Markdown
Collaborator Author

/backport! to stable31 please

@silverkszlo

Copy link
Copy Markdown
Collaborator Author

/backport! to stable30 please

@backportbot

backportbot Bot commented Aug 5, 2026

Copy link
Copy Markdown

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/8951/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5b6d66ed ee7268cf

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8951/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants