Replace id to class for files app - #2745
Merged
Merged
Conversation
22 tasks
PVince81
changed the title
Member
|
Cypress tests should cover most of the files app integration bits, so this looks reasonable to do from the text app side 馃憤 |
PVince81
force-pushed
the
bugfix/noid/remote-files-duplicate-dom-ids
branch
from
July 26, 2022 07:51
bf72df6 to
ec7cdd2
Compare
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/noid/remote-files-duplicate-dom-ids
branch
from
July 26, 2022 08:40
ec7cdd2 to
cd3e88e
Compare
Member
Author
|
conflict solved |
Member
Author
|
all green |
PVince81
force-pushed
the
bugfix/noid/remote-files-duplicate-dom-ids
branch
from
July 26, 2022 10:21
cd3e88e to
259d554
Compare
PVince81
marked this pull request as ready for review
July 26, 2022 10:22
Member
Author
|
I assume your thumbs up was intended to be an approval @juliushaertl |
delete-merged-branch
Bot
deleted the
bugfix/noid/remote-files-duplicate-dom-ids
branch
July 26, 2022 10:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nextcloud/server#33320