You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug]: Share without "download" permission blocks readme.md #7023
It is expected as the viewer uses webdav to download the files. If that is not allowed we can not show them
@susnux the WEBDAV dependecy is now better understood.
replicating the test today came with same result above that also photos could not be shown if download disabled. Looks this is a NC architecture isseu then.
We should implement support for allowViewWithoutDownload in Text and support opening editing sessions when it's set. Relevant server PR that implemented this flag: nextcloud/server#53671.
The restriction was added in #2776. I guess we have to add a check for the allowViewWithoutDownload config flag at ApiService.php::create().
This code probably can go completely as DocumentService.php::checkSharePermission() no longer checks the config flag and no longer throws NotPermittedExecption. So this looks like dead code to me.
We should implement support for allowViewWithoutDownload in Text and support opening editing sessions when it's set.
How complicated is it, to implement a solution for this?
Today, as an admin, it took me a while to realise that it might be caused by Markdown as the file format.
Activity
susnux commentedon Feb 14, 2024
It is expected as the viewer uses webdav to download the files. If that is not allowed we can not show them
moritzthecat commentedon Jun 28, 2024
@susnux the WEBDAV dependecy is now better understood.
replicating the test today came with same result above that also photos could not be shown if download disabled. Looks this is a NC architecture isseu then.
mejo- commentedon Apr 23, 2026
We should implement support for
allowViewWithoutDownloadin Text and support opening editing sessions when it's set. Relevant server PR that implemented this flag: nextcloud/server#53671.The restriction was added in #2776. I guess we have to add a check for the
allowViewWithoutDownloadconfig flag atApiService.php::create().This code probably can go completely as
DocumentService.php::checkSharePermission()no longer checks the config flag and no longer throwsNotPermittedExecption. So this looks like dead code to me.moritzthecat commentedon Apr 24, 2026
@mejo- suggest to review a more general RBAC approach to include [viewing, downloading, commenting and tagging] as outlined here.
4jNsY6fCVqZv commentedon Oct 28, 2026
How complicated is it, to implement a solution for this?
Today, as an admin, it took me a while to realise that it might be caused by Markdown as the file format.
fix(share): allow viewing files in shares with download disabled
fix(share): allow viewing files in shares with download disabled
fix(share): allow viewing files in shares with download disabled
fix(share): allow viewing files in shares with download disabled
fix(share): allow viewing files in shares with download disabled