Skip to content

Bugfix/4909/fix markdown links - #6289

Merged
mahibi merged 2 commits into
masterfrom
bugfix/4909/fixMarkdownLinks
Jun 3, 2026
Merged

Bugfix/4909/fix markdown links#6289
mahibi merged 2 commits into
masterfrom
bugfix/4909/fixMarkdownLinks

Conversation

@mahibi

@mahibi mahibi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

fix #4909

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

mahibi added 2 commits June 3, 2026 14:56
   Ensure markdown links like [text](https://example.com) are treated as real links in chat messages.

   - Preserve Markwon URL spans when running Linkify
   - Detect existing markdown link spans when deciding whether to enable LinkMovementMethod
   - Replace the no-op Markwon linkResolver with ACTION_VIEW handling so taps open the URL

AI-assistant: GitHub Copilot 1.9.1-251 (GPT-5.3-Codex)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
   Add Open Graph preview support for URLs embedded in markdown links.

   - Extract URL targets from markdown syntax ([label](url)) during link-preview URL detection
   - Reuse existing LinkMessage/OpenGraph rendering flow once a URL is extracted
   - Add unit tests to cover plain URL extraction and markdown URL extraction

AI-assistant: GitHub Copilot 1.9.1-251 (GPT-5.3-Codex)
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi

mahibi commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-24.0

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/26886323906/artifacts/7386073491
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi
mahibi merged commit c73c507 into master Jun 3, 2026
16 of 20 checks passed
@mahibi
mahibi deleted the bugfix/4909/fixMarkdownLinks branch June 3, 2026 14:04
@mahibi mahibi mentioned this pull request Jun 15, 2026
5 tasks
@AndyScherzinger AndyScherzinger modified the milestones: 24.1.0, 25.0.0 Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[markdown](https://nextcloud.com) does not appear as a link in a normal message, but does so when that message is quoted

2 participants