Skip to content

fix(http): strip control characters from download filename fallback - #66850

Open
lazerg wants to merge 2 commits into
nextcloud:masterfrom
lazerg:fix/issue-66847-download-fallback-control-chars
Open

lazerg wants to merge 2 commits into
nextcloud:masterfrom
lazerg:fix/issue-66847-download-fallback-control-chars

Conversation

@lazerg

@lazerg lazerg commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Downloading a file whose name has a newline or tab (for example a Forms CSV export when the form title was pasted) fails with a 500. UnicodeString::ascii() keeps ASCII control characters and Symfony rejects them in the fallback filename. They are now replaced with a space in the filename, and the fallback drops anything outside printable ASCII.

TODO

  • Fix the fallback filename

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: lazerg <lazerg2@gmail.com>
@lazerg
lazerg requested a review from a team as a code owner November 20, 2026 09:30
@lazerg
lazerg requested review from icewind1991 and salmart-dev and removed request for a team November 20, 2026 09:30
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: lazerg <lazerg2@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DownloadResponse throws 500 when filename contains control characters

1 participant