Repository navigation
feat(ocm): Allow apps to supply server for http-sig verification - #66642
Open
mickenordin wants to merge 2 commits into
Open
mickenordin wants to merge 2 commits into
mickenordin wants to merge 2 commits into
Conversation
mickenordin
requested review from
CarlSchwan and
provokateurin
and removed request for
a team
November 16, 2026 10:09
5 tasks done
Contributor
Author
|
This is the result: This was produced by: https://code.smolnet.org/micke/federated_groups |
Pass verified signed requests to OCM endpoint listeners and expose integrity-protected signature parameters. Assisted-by: OpenCode:gpt-daybreak-blue-latest Signed-off-by: Micke Nordin <kano@sunet.se>
Dispatch endpoint context before signature verification so listeners can select the OCM identity used to resolve the signer. Deduplicate matching claims and reject conflicts. Assisted-by: OpenCode:gpt-daybreak-blue-latest Signed-off-by: Micke Nordin <kano@sunet.se>
mickenordin
force-pushed
the
kano-key-package-request-context-trimmed
branch
from
November 17, 2026 19:52
2cf0974 to
89ae21e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mls-key-packages endpoint takes a senderDomain param from which to derive where to find the key to verify the signature. Rather than add this special case to the cloud_federation_api, I introduce a general mechanism to supply this information, since it would be ugly to have a special case for an endpoint that may not be implemented in that app. It works with #66633 to make it possible to create the /ocm/mls-key-packages endpoint.
Checklist
3. to review, feature component)stable32)AI (if applicable)