Repository navigation
feat: send unified shares to remote instances via ocm - #66569
Draft
cristianscheid wants to merge 1 commit into
Draft
cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
cristianscheid
force-pushed
the
feat/64711/unified-sharing-ocm
branch
from
November 13, 2026 18:37
e2e1771 to
7967497
Compare
cristianscheid
force-pushed
the
feat/64711/unified-sharing-ocm
branch
from
November 13, 2026 18:44
7967497 to
12e82b9
Compare
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
feat/64711/unified-sharing-ocm
branch
from
November 13, 2026 18:48
12e82b9 to
7ef478b
Compare
Contributor
|
For this, I would really recommend setting up at least OpenCloud and trying to share to that, and make sure it still works. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when creating a unified share with a user living in remote instance, share is only created locally and not propagated. The goal of this PR is to send the unified share to remote instance OCM /shares endpoint, so it can be created there as well.
The unified share is sent to remote instances only if it contains remote recipients, in the following events:
In the case where a unified share is composed by multiple sources, one OCM share is sent to each source. To be able to assemble the share again on receiving end, the OCM
providerIdfield is formatted like this:As per OCM docs, this value must be unique per resource and per share.
This is only a first iteration of development that focuses on sending the necessary data to the remote instance. The receiving part was not yet modified, and for now, stores the share in legacy format (oc_share_external).
Also, after receiving the OCM share, the receiving end is supposed to send callbacks back to the sender (token exchange and share accepted). This is not working for now and exceptions are thrown, because sender still looks up the for share secret in the legacy table oc_share, but it's not there since it is a unified share.
To test this:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)