Repository navigation
Conversation
vlotysh
requested review from
CarlSchwan,
GhassenKefi,
icewind1991,
kristian-zendato,
pabzm and
susnux
and removed request for
a team
November 13, 2026 15:13
vlotysh
force-pushed
the
feat/restrict-allowed-file-types-share
branch
from
November 13, 2026 15:21
15a0d06 to
7c64154
Compare
vlotysh
force-pushed
the
feat/restrict-allowed-file-types-share
branch
3 times, most recently
from
November 15, 2026 18:35
5a07907 to
61382c1
Compare
icewind1991
approved these changes
Nov 17, 2026
icewind1991
left a comment
Member
There was a problem hiding this comment.
Backend wise, looks good otherwise
| /** | ||
| * @param class-string $collectionClass | ||
| */ | ||
| private function isChildOf(string $path, string $collectionClass): bool { |
Member
There was a problem hiding this comment.
The name of the method doesn't really match the functionality (anymore?).
|
|
||
| $linkCheckPlugin = new PublicLinkCheckPlugin(); | ||
| $filesDropPlugin = new FilesDropPlugin(); | ||
| $allowedFileTypesPlugin = new AllowedFileTypesPlugin(Server::get(IMimeTypeDetector::class)); |
Member
There was a problem hiding this comment.
You can directly get the AllowedFileTypesPlugin from Server::get instead of just it's constructor parameter.
This mainly removes friction if the params of AllowedFileTypesPlugin ever need to be changed in the future.
Signed-off-by: Vladyslav Lotysh <lotysh.vm@gmail.com> Assisted-by: ClaudeCode:claude-opus-5-5
vlotysh
force-pushed
the
feat/restrict-allowed-file-types-share
branch
from
November 17, 2026 18:58
61382c1 to
cb0b075
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMimeTypeDetector::detectPath(), the file content is not inspected.PUT→beforeBind→415 Unsupported Media Type.MKCOL uploads/<token>/<id>with aDestinationheader →beforeMkcol→ 415 before the first chunk is sent.MOVE .fileis checked inbeforeBindagainst the destination name, before the chunks are assembled.MOVE/COPYof collections that are not part of the share (upload folders) → 403.upload.allowed_typesattribute are not affected.before

after

Checklist
3. to review, feature component)stable32)AI (if applicable)