Skip to content

[stable35] fix(federation): compare tokens in the shared secret job - #66420

Open
backportbot[bot] wants to merge 1 commit into
stable35from
backport/66359/stable35
Open

backportbot[bot] wants to merge 1 commit into
stable35from
backport/66359/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 6, 2026

Copy link
Copy Markdown

Backport of PR #66359

When both servers start the shared secret exchange, the one with the
greater token asks for the secret. Do this check in the GetSharedSecret
job instead of the request handler, so the handler only checks the
server and queues the job. Tokens are generated with 16 characters, so
refuse anything longer than 64.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@backportbot
backportbot Bot requested a review from a team as a code owner November 6, 2026 20:06
@backportbot
backportbot Bot requested review from leftybournes, salmart-dev, skjnldsv, susnux and szaimen and removed request for a team November 6, 2026 20:06
@backportbot backportbot Bot added bug 3. to review Waiting for reviews AI assisted labels Nov 6, 2026
@backportbot backportbot Bot added this to the Nextcloud 35.0.3 milestone Nov 6, 2026
This was referenced Nov 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants