Skip to content

refactor(session): use ITimeFactory for superseded session markers - #66323

Merged
DerDreschner merged 1 commit into
masterfrom
fix/use-time-factory
Nov 5, 2026
Merged

DerDreschner merged 1 commit into
masterfrom
fix/use-time-factory

Conversation

@DerDreschner

Copy link
Copy Markdown
Member

Summary

In my previous PR (#65928), I used time() instead of the correct way (ITimeFactory). This is fixed with this refactor.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@DerDreschner DerDreschner self-assigned this Nov 4, 2026
@DerDreschner
DerDreschner requested a review from a team as a code owner November 4, 2026 17:23
@DerDreschner DerDreschner added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) AI assisted labels Nov 4, 2026
@DerDreschner
DerDreschner requested review from ChristophWurst, icewind1991, salmart-dev, solracsf and susnux and removed request for a team November 4, 2026 17:23
@DerDreschner

Copy link
Copy Markdown
Member Author

/backport! to stable35

@DerDreschner

Copy link
Copy Markdown
Member Author

/backport! to stable34

@DerDreschner

Copy link
Copy Markdown
Member Author

/backport! to stable33

@backportbot

This comment was marked as outdated.

@backportbot

This comment was marked as outdated.

@DerDreschner
DerDreschner merged commit 3c92f06 into master Nov 5, 2026
166 of 174 checks passed
@DerDreschner
DerDreschner deleted the fix/use-time-factory branch November 5, 2026 06:37
@nextcloud nextcloud deleted a comment from backportbot Bot Nov 5, 2026
@nextcloud nextcloud deleted a comment from backportbot Bot Nov 5, 2026
@nextcloud nextcloud deleted a comment from backportbot Bot Nov 5, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to review Waiting for reviews AI assisted ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants