Repository navigation
fix(dav): bind public share session authentication to the password hash - #66178
Merged
Merged
Conversation
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
susnux
marked this pull request as ready for review
November 3, 2026 12:29
susnux
requested review from
a team,
Altahrim,
CarlSchwan,
GhassenKefi,
cristianscheid,
icewind1991,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team,
icewind1991,
salmart-dev and
sorbaugh
November 3, 2026 12:29
The public DAV backends and the federated "add to your Nextcloud" endpoint remembered a verified share password as a bare share id in the session. Validate against the share token => password hash map that the public share page already uses instead, so the session entry only matches while the share password is unchanged. The legacy `public_link_authenticated` id list is still written by the share page for other apps, but no longer read by server. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Skip remembering the share in the session unless its password is hashed, and compare the stored hash with hash_equals(). Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/dav-public-share-session
branch
from
November 3, 2026 12:52
453c92e to
745bd1d
Compare
provokateurin
approved these changes
Nov 3, 2026
GhassenKefi
approved these changes
Nov 3, 2026
AndyScherzinger
approved these changes
Nov 3, 2026
This was referenced Nov 3, 2026
Contributor
|
This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public DAV backends and the federated "add to your Nextcloud" endpoint remembered a verified share password as a bare share id in the session. Validate against the share token => password hash map that the public share page already uses instead, so the session entry only matches while the share password is unchanged.
The legacy
public_link_authenticatedid list is still written by the share page for other apps, but no longer read by server.👁️ I look at you
textapp 👁️Checklist
3. to review, feature component)stable32)AI (if applicable)