Skip to content

[stable35] fix(appstore): do not wrap app store screenshots in the proxy twice - #65991

Merged
edward-ly merged 1 commit into
stable35from
backport/64771/stable35
Oct 29, 2026
Merged

edward-ly merged 1 commit into
stable35from
backport/64771/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 28, 2026

Copy link
Copy Markdown

Backport of PR #64771

The app store now serves screenshot URLs already pointing at
usercontent.apps.nextcloud.com. Wrapping them again names a file the
proxy never stores the image under, so no app shows its screenshot.

Pass such URLs through unchanged, and encode the others with the URL-safe
alphabet the proxy stores its files under.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
@backportbot
backportbot Bot requested a review from a team as a code owner October 28, 2026 20:57
@backportbot
backportbot Bot removed the request for review from a team October 28, 2026 20:57
@backportbot backportbot Bot added php Pull requests that update Php code feedback-requested community pull requests from community labels Oct 28, 2026
@backportbot backportbot Bot added this to the Nextcloud 35.0.3 milestone Oct 28, 2026
@edward-ly
edward-ly merged commit a323fe5 into stable35 Oct 29, 2026
155 of 161 checks passed
@edward-ly
edward-ly deleted the backport/64771/stable35 branch October 29, 2026 16:44
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to review Waiting for reviews bug community pull requests from community feature: apps management feedback-requested php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants