Repository navigation
Conversation
…vent Whether an attendee gets an iMIP mail was decided on the event as a whole: any new recurrence exception grew every attendee's set of instances, and the significant-change hash covered all components. Processing a REPLY for a single occurrence, or adding or removing an attendee on one occurrence, therefore mailed every attendee. Decide significance per attendee instead, over the occurrences they take part in before or after the change. A new exception that matches the occurrence it replaces, such as one storing another attendee's participation status, is not significant. The attendee's calendar copy is still updated. Fixes nextcloud#60452 Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Rikdekker <Rikdekker@users.noreply.github.com>
|
/backport to stable35 |
|
/backport to stable34 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
When something changes for a single occurrence of a recurring event, every attendee gets an iMIP mail, even when nothing changed for them. This happens when an attendee declines one occurrence (processing the REPLY adds an override to the organizer's copy), and when the organizer adds or removes someone on one occurrence.
TipBroker::parseEventForOrganizerdecides significance for the event as a whole, for two reasons:significantChangeHashis computed over all components, so any new override changes it for everyone.This PR decides significance per attendee instead, over the occurrences they take part in before or after the change. A new override that matches the occurrence it replaces, such as one that only stores another attendee's PARTSTAT, is not significant. Attendees' calendar copies are still updated; they just don't get a mail for it.
Testing
TipBrokerTest; 5 of them fail on master. The CalDAV unit suite passes (776 tests), and psalm and php-cs-fixer are clean.This complements #64635: that PR makes sure the added or removed attendee gets a mail at all, and this one stops the mails to everyone else. With both applied, only the affected attendee is notified. It builds on #64317, which handled the series-level case.
Checklist
3. to review, feature component)stable32)AI (if applicable)
The analysis, fix and tests were made with the help of Claude Code (Anthropic). I verified the results myself on a 35.0.2 instance.