fix: multiple file selection on tab navigation - #62482
Conversation
38556bb to
b102334
Compare
| <FilesListTableHeaderActions | ||
| :current-view="currentView" | ||
| :selected-nodes="selectedNodes" /> | ||
| </th> |
There was a problem hiding this comment.
This is not correct, this is not the table header - the table is still in DOM, so:
- the headers do not match the table cells anymore (2 headers but 5 columns)
- the table header is not correct it labels the "name" row with invalid content
There are two options to fix it:
- Keep this approach but do not remove the proper headers but make them "hidden" and add this "batch" content to the
thof the select-all checkbox. - Keep previous overlay approach but allow properly tab outside of the actions
b102334 to
bb70a03
Compare
| <!-- eslint-disable-next-line vue/singleline-html-element-content-newline -- no space allowed as otherwise `:empty` css selector does not trigger! --> | ||
| <template #filters><FileListFilterToSearch /><FileListFilterChips /></template> | ||
|
|
||
| <template v-if="!isNoneSelected" #header-overlay> |
There was a problem hiding this comment.
Is the header-overlay slot then still used? Otherwise please remove the slot definition as well to prevent dead code piling up :)
bb70a03 to
0d309ff
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
0d309ff to
ba05312
Compare
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
ba05312 to
3a92c62
Compare
|
/backport to stable34 |
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/62482/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3a92c629
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62482/stable33Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/62482/stable33."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/62482/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3a92c629
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62482/stable34Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/62482/stable34."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
3 participants
Summary
Keyboard-only multi-select in the files list was broken: after selecting a file, focus was trapped between the “select all” checkbox and the batch actions overlay, so Tab/Shift+Tab could not reach file rows again (regression from #58457).
This removes the custom Tab/focusout focus trapping between the select-all checkbox and the first batch action button in FilesListTableHeader.vue and FilesListTableHeaderActions.vue, so focus follows the normal document order and keyboard multi-select works again.
This replaces the table header with Table Header Actions when any file is select to ensure the right tab sequence.
Checklist
3. to review, feature component)stable32)AI (if applicable)