Skip to content

fix(settings): add loading feedback to account create/edit dialogs - #60986

Merged
pringelmann merged 1 commit into
masterfrom
fix/account-dialog-loading-feedback
Jun 18, 2026
Merged

fix(settings): add loading feedback to account create/edit dialogs#60986
pringelmann merged 1 commit into
masterfrom
fix/account-dialog-loading-feedback

Conversation

@pringelmann

@pringelmann pringelmann commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

While an account is being created or edited, the dialog now shows clear progress: the submit button gets a spinner and a busy label, the form is locked, and the close button is disabled until the request settles. The submit button uses aria-disabled rather than disabled so the loading state stays announced to screen readers, with a guard preventing re-submit.

Note: the save endpoints used in the recording below are intentionally delayed to demonstrate the fix.

Before:

user-modal-save_before.mp4

After:

user-modal-save_after.mp4

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly generated using AI

Tests authored with Claude Code (Opus). All tests were manually reviewed.

@pringelmann pringelmann self-assigned this Jun 4, 2026
@pringelmann pringelmann added this to the Nextcloud 34.0.1 milestone Jun 4, 2026
@pringelmann
pringelmann force-pushed the fix/account-dialog-loading-feedback branch 3 times, most recently from 3b4bc45 to a515e93 Compare June 4, 2026 16:47
@pringelmann
pringelmann marked this pull request as ready for review June 4, 2026 16:56
@pringelmann
pringelmann requested a review from a team as a code owner June 4, 2026 16:56
@pringelmann
pringelmann requested review from nfebe, sorbaugh and susnux and removed request for a team June 4, 2026 16:56
@pringelmann

Copy link
Copy Markdown
Contributor Author

/compile amend

@nextcloud-command
nextcloud-command force-pushed the fix/account-dialog-loading-feedback branch from a515e93 to 83687c8 Compare June 4, 2026 17:06
@susnux susnux modified the milestones: Nextcloud 34.0.1, Nextcloud 35 Jun 9, 2026
@pringelmann
pringelmann requested a review from artonge June 17, 2026 13:51
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@pringelmann
pringelmann force-pushed the fix/account-dialog-loading-feedback branch from 83687c8 to c3dcffd Compare June 18, 2026 08:05
@pringelmann
pringelmann merged commit 48613df into master Jun 18, 2026
141 of 144 checks passed
@pringelmann
pringelmann deleted the fix/account-dialog-loading-feedback branch June 18, 2026 09:25
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[Bug]: accounts -> new account UX improvable

4 participants