fix(settings): add loading feedback to account create/edit dialogs - #60986
Merged
Conversation
pringelmann
force-pushed
the
fix/account-dialog-loading-feedback
branch
3 times, most recently
from
June 4, 2026 16:47
3b4bc45 to
a515e93
Compare
pringelmann
marked this pull request as ready for review
June 4, 2026 16:56
pringelmann
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
June 4, 2026 16:56
Contributor
Author
|
/compile amend |
nextcloud-command
force-pushed
the
fix/account-dialog-loading-feedback
branch
from
June 4, 2026 17:06
a515e93 to
83687c8
Compare
CarlSchwan
approved these changes
Jun 8, 2026
artonge
approved these changes
Jun 17, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
pringelmann
force-pushed
the
fix/account-dialog-loading-feedback
branch
from
June 18, 2026 08:05
83687c8 to
c3dcffd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While an account is being created or edited, the dialog now shows clear progress: the submit button gets a spinner and a busy label, the form is locked, and the close button is disabled until the request settles. The submit button uses
aria-disabledrather thandisabledso the loading state stays announced to screen readers, with a guard preventing re-submit.Before:
user-modal-save_before.mp4
After:
user-modal-save_after.mp4
Checklist
3. to review, feature component)stable32)AI (if applicable)
Tests authored with Claude Code (Opus). All tests were manually reviewed.