fix(files): keep reactivity when destructure store - #59942
Merged
Conversation
susnux
added
bug
3. to review
susnux
added
bug
3. to review
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/compile |
Merged
kesselb
approved these changes
Apr 27, 2026
Contributor
Author
|
/compile rebase |
- resolves #59941 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/view-destructure
branch
from
April 27, 2026 18:11
270be79 to
caf287d
Compare
susnux
enabled auto-merge
April 27, 2026 18:30
skjnldsv
approved these changes
Apr 28, 2026
3 tasks
Merged
Merged
Merged
6 tasks
ELHart05
added a commit
to ELHart05/server
that referenced
this pull request
Aug 12, 2026
FileEntryGrid destructured useActiveStore() directly, so activeFolder, activeNode and activeView were plain snapshots taken when the entry was first rendered. Opening a file from grid view therefore handed the file actions a stale folder, and the viewer navigated the list to whichever folder happened to be active back then: from a nested folder this drops you at the root, or a level or two above, with the file open on top. Same fix as nextcloud#59942, which covered FileEntry but left its grid counterpart behind despite the "keep in sync with FileEntry.vue" note above it. Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>
ELHart05
added a commit
to ELHart05/server
that referenced
this pull request
Aug 16, 2026
FileEntryGrid destructured useActiveStore() directly, so activeFolder, activeNode and activeView were plain snapshots taken when the entry was first rendered. Opening a file from grid view therefore handed the file actions a stale folder, and the viewer navigated the list to whichever folder happened to be active back then: from a nested folder this drops you at the root, or a level or two above, with the file open on top. Same fix as nextcloud#59942, which covered FileEntry but left its grid counterpart behind despite the "keep in sync with FileEntry.vue" note above it. Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)AI (if applicable)