fix(files_sharing): Stop hiding delete share button in advanced settings menu - #53639
Merged
provokateurin merged 2 commits intoJun 30, 2025
Merged
Conversation
provokateurin
requested review from
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
June 23, 2025 07:47
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
yemkareems
approved these changes
Jun 30, 2025
susnux
reviewed
Jun 30, 2025
susnux
reviewed
Jun 30, 2025
susnux
approved these changes
Jun 30, 2025
…ngs menu Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/files_sharing/advanced-settings-delete-share-button
branch
from
June 30, 2025 11:01
66dbe2a to
d55b1ee
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
provokateurin
deleted the
fix/files_sharing/advanced-settings-delete-share-button
branch
June 30, 2025 11:37
This was referenced Jun 30, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a share is not an "advanced setting", so the button should not be hidden if the menu is collapsed.
Before:
After:
Checklist