Add .aac mime type mapping - #42542
Merged
Merged
Conversation
AndyScherzinger
force-pushed
the
aac-mimetype
branch
from
February 26, 2024 10:05
a36cbd6 to
511e192
Compare
AndyScherzinger
approved these changes
Feb 26, 2024
szaimen
requested review from
juliusknorr and
skjnldsv
and removed request for
szaimen
February 26, 2024 10:12
juliusknorr
previously requested changes
Feb 26, 2024
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Just this change won't be enough, you may want to checkout https://github.com/nextcloud/server/pull/10135/files as a reference to also add a repair step fixing this for existing files.
Unpublished
force-pushed
the
aac-mimetype
branch
2 times, most recently
from
February 26, 2024 13:51
9a87e60 to
58edb64
Compare
Signed-off-by: Unpublished <Unpublished@users.noreply.github.com>
AndyScherzinger
force-pushed
the
aac-mimetype
branch
from
February 27, 2024 13:44
58edb64 to
4af1c5c
Compare
Member
|
@juliushaertl changes seem to be addressed. Can you re-review/approve? 😃 |
skjnldsv
approved these changes
Feb 27, 2024
skjnldsv
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds .aac mime type mapping
Checklist