feat: Print early exceptions in debug mode instead of plain error pages - #42045
Merged
Conversation
juliusknorr
requested review from
a team,
ArtificialOwl,
blizzz,
icewind1991,
nfebe and
nickvergessen
and removed request for
a team
December 5, 2023 20:48
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($debug) { | ||
| print("\n"); | ||
| print($exception->getMessage() . ' ' . $exception->getFile() . ' at ' . $exception->getLine() . "\n"); | ||
| print($exception->getTraceAsString()); |
Check failure
Code scanning / Psalm
TaintedHtml
| if ($debug) { | ||
| print("\n"); | ||
| print($exception->getMessage() . ' ' . $exception->getFile() . ' at ' . $exception->getLine() . "\n"); | ||
| print($exception->getTraceAsString()); |
Check failure
Code scanning / Psalm
TaintedTextWithQuotes
blizzz
approved these changes
Jan 15, 2024
skjnldsv
approved these changes
Feb 23, 2024
skjnldsv
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
force-pushed
the
enh/early-exception-print
branch
from
February 23, 2024 14:57
289f093 to
efc3d76
Compare
skjnldsv
enabled auto-merge
February 23, 2024 18:08
skjnldsv
disabled auto-merge
February 23, 2024 18:24
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhances error pages of early thrown exceptions where we cannot render a template to display the actual exception details. Only applied in debug mode as with the regular exception rendering.
Checklist