[stable25] Fix: non responsive app navigation toggle - #41092
Merged
Conversation
hamza221
requested review from
artonge,
nfebe and
sorbaugh
and removed request for
a team
October 24, 2023 16:41
Contributor
|
@hamza221 did you forget to commit the library changes? Looks like the compiled assets contain a different version but the package.json was not updated? |
Member
Could also be from a compilation with old packages. E.g. no |
Merged
ChristophWurst
changed the title
Member
ChristophWurst
changed the title
artonge
approved these changes
Nov 14, 2023
ChristophWurst
force-pushed
the
fix/non-responsive-app-navigation-toggle
branch
from
November 16, 2023 08:09
4c6e32f to
e945b1b
Compare
AndyScherzinger
approved these changes
Nov 16, 2023
AndyScherzinger
force-pushed
the
fix/non-responsive-app-navigation-toggle
branch
from
November 16, 2023 12:43
e945b1b to
a608097
Compare
ChristophWurst
approved these changes
Nov 22, 2023
ChristophWurst
added
4. to release
blizzz
force-pushed
the
fix/non-responsive-app-navigation-toggle
branch
from
November 22, 2023 20:44
a608097 to
107c29b
Compare
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
AndyScherzinger
force-pushed
the
fix/non-responsive-app-navigation-toggle
branch
from
November 25, 2023 09:33
107c29b to
6cfface
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screencast from 2023-10-24 18-40-13.webm
Caused by f2de58d
would appreciate other suggestions to fix this.
TODO
Checklist