Migrate away from ILogger in encryption - #39065
Merged
Merged
Conversation
24 tasks
come-nc
requested review from
a team,
ArtificialOwl,
artonge,
icewind1991 and
nfebe
and removed request for
a team
June 29, 2023 13:44
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
reviewed
Jun 29, 2023
nfebe
left a comment
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Logger migration looks consistent to me, left inline comments about code comments and type hinting.
nfebe
approved these changes
Jun 29, 2023
nfebe
left a comment
nfebe
left a comment
Contributor
There was a problem hiding this comment.
Sorry I did not mention all the hint improvements, I guess if you are feeling good you can amend the latest improvements to last commit.
Thanks!
artonge
approved these changes
Jul 3, 2023
|
|
||
| /** @var array */ | ||
| private $owner; | ||
| private array $owner; |
Collaborator
There was a problem hiding this comment.
Why is it the only one getting a type?
come-nc
force-pushed
the
fix/remove-ilogger-uses-in-encryption
branch
2 times, most recently
from
August 3, 2023 12:26
7b515c1 to
b1a7d07
Compare
And modernize code a bit Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…tructors Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-ilogger-uses-in-encryption
branch
from
August 8, 2023 07:14
b1a7d07 to
3e176f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate away from ILogger in encryption and switch to constructor parameter promotion in concerned classes.
See #32127
Checklist