chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript

[ChristophWurst]

Summary

Deprecated in Nextcloud 10, released 2016-08-25.

TODO

• Stop usage of \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript  richdocuments#2979

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[juliusknorr]

Tests need some more adjustments:

There were 7 errors:

1) Test\AppFramework\Http\ContentSecurityPolicyTest::testGetPolicyScriptAllowInline
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/AppFramework/Http/ContentSecurityPolicyTest.php:74

2) Test\AppFramework\Http\ContentSecurityPolicyTest::testGetPolicyScriptAllowInlineWithDomain
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/AppFramework/Http/ContentSecurityPolicyTest.php:82

3) Test\AppFramework\Http\ContentSecurityPolicyTest::testGetPolicyScriptDisallowInlineAndEval
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/AppFramework/Http/ContentSecurityPolicyTest.php:89

4) Test\AppFramework\Http\ResponseTest::testOverwriteCsp
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/AppFramework/Http/ResponseTest.php:70

5) Test\AppFramework\Http\ResponseTest::testGetCsp
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/AppFramework/Http/ResponseTest.php:80

6) Test\Security\CSP\ContentSecurityPolicyManagerTest::testGetDefaultPolicyWithPolicies
Error: Call to undefined method OCP\AppFramework\Http\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/Security/CSP/ContentSecurityPolicyManagerTest.php:59

7) Test\Security\CSP\ContentSecurityPolicyManagerTest::testGetDefaultPolicyWithPoliciesViaEvent
Error: Call to undefined method OC\Security\CSP\ContentSecurityPolicy::allowInlineScript()

/drone/src/tests/lib/Security/CSP/ContentSecurityPolicyManagerTest.php:113

[szaimen]

CI failure related

[ChristophWurst]

Which ones @szaimen except the expected fixup and DCO checks?

[szaimen]

Which ones @szaimen except the expected fixup and DCO checks?

yes, I meant these :)