Skip to content

Cleanup oauth2 admin settings - #32521

Merged
CarlSchwan merged 1 commit into
masterfrom
cleanup/oauth2-admin-setting
Jul 18, 2022
Merged

Cleanup oauth2 admin settings#32521
CarlSchwan merged 1 commit into
masterfrom
cleanup/oauth2-admin-setting

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented May 20, 2022

Copy link
Copy Markdown
Member
  • Use more vue components
  • Add link to doc

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label May 20, 2022
@CarlSchwan
CarlSchwan requested a review from a team May 20, 2022 15:09
@CarlSchwan CarlSchwan self-assigned this May 20, 2022
@CarlSchwan
CarlSchwan requested review from PVince81, Pytal and vanpertsch and removed request for a team May 20, 2022 15:09
@CarlSchwan
CarlSchwan force-pushed the cleanup/oauth2-admin-setting branch from fb651fe to 20c77ce Compare May 20, 2022 15:23
Pytal
Pytal reviewed May 20, 2022
View reviewed changes
Comment thread apps/oauth2/tests/Settings/AdminTest.php Outdated
Comment thread apps/oauth2/src/App.vue Outdated
@CarlSchwan
CarlSchwan force-pushed the cleanup/oauth2-admin-setting branch from 20c77ce to cf3ccbe Compare May 20, 2022 20:15
Pytal
Pytal reviewed May 20, 2022
View reviewed changes
Comment thread apps/oauth2/src/App.vue Outdated
@CarlSchwan
CarlSchwan force-pushed the cleanup/oauth2-admin-setting branch 2 times, most recently from 4e16b7e to 743dc1c Compare May 23, 2022 10:37
Pytal
Pytal reviewed May 25, 2022
View reviewed changes
Comment thread apps/oauth2/tests/Settings/AdminTest.php
Pytal
Pytal reviewed May 25, 2022
View reviewed changes
Comment thread apps/oauth2/src/components/OAuthItem.vue Outdated
@CarlSchwan
CarlSchwan force-pushed the cleanup/oauth2-admin-setting branch from 743dc1c to 5c3a459 Compare June 21, 2022 16:39
@CarlSchwan

CarlSchwan commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

/rebase

@CarlSchwan
Cleanup oauth2 admin settings
53db418 
- Use more vue components
- Add link to doc

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan force-pushed the cleanup/oauth2-admin-setting branch from 5c3a459 to 53db418 Compare July 14, 2022 10:16
@github-actions

github-actions Bot commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@CarlSchwan
CarlSchwan merged commit 6a6ce39 into master Jul 18, 2022
@CarlSchwan
CarlSchwan deleted the cleanup/oauth2-admin-setting branch July 18, 2022 09:47
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
@ChristophWurst ChristophWurst mentioned this pull request Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes
@Pytal Pytal Pytal approved these changes
@PVince81 PVince81 Awaiting requested review from PVince81
@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @artonge @Pytal