Update core to PHP 7.4 standard - #31948
Merged
Merged
Conversation
CarlSchwan
requested review from
blizzz and
juliusknorr
and removed request for
a team
April 12, 2022 15:57
CarlSchwan
force-pushed
the
core-cleanup-74
branch
3 times, most recently
from
April 12, 2022 16:23
eed82c5 to
55a4fa2
Compare
artonge
reviewed
Apr 12, 2022
CarlSchwan
force-pushed
the
core-cleanup-74
branch
from
April 12, 2022 16:32
55a4fa2 to
350053d
Compare
Member
Author
|
found some issues, don't merge |
blizzz
added
2. developing
24 tasks
come-nc
reviewed
May 5, 2022
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Please rebase and fix or explain the issues
CarlSchwan
force-pushed
the
core-cleanup-74
branch
2 times, most recently
from
May 6, 2022 13:50
4e7cb13 to
ea926ef
Compare
Member
Author
Fixed the issues found last time and all the unit tests now pass (needed to change from ILogger to LoggerInterface there too) |
come-nc
requested changes
May 9, 2022
CarlSchwan
force-pushed
the
core-cleanup-74
branch
from
May 9, 2022 09:13
ea926ef to
f179e96
Compare
come-nc
approved these changes
May 9, 2022
CarlSchwan
force-pushed
the
core-cleanup-74
branch
from
May 9, 2022 09:31
f179e96 to
946d75a
Compare
- Typed properties - Port to LoggerInterface Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
core-cleanup-74
branch
from
May 20, 2022 20:18
946d75a to
b70c6a1
Compare
Contributor
artonge
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carl Schwan carl@carlschwan.eu